Open
Conversation
austinweisgrau
force-pushed
the
daisychain
branch
from
bd7d391 to
e1957ba
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
shaunagm
added
the
new connector
Collaborator
|
@austinweisgrau is this still a work in progress? It's missing docs and tests but I can do a review of the code if you want, or I can wait til you're ready |
Collaborator
Author
|
The code is good to go! I should prob add docs and tests tho huh
…On Tue, Feb 18, 2025, 1:57 PM Shauna Gordon-McKeon ***@***.***> wrote:
@austinweisgrau <https://github.com/austinweisgrau> is this still a work
in progress? It's missing docs and tests but I can do a review of the code
if you want, or I can wait til you're ready
—
Reply to this email directly, view it on GitHub
<#1283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO74QHTB7PQU2UWZQFPZJ5L2QOUDJAVCNFSM6AAAAABWVBE4OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGAYTGNJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: shaunagm]*shaunagm* left a comment (move-coop/parsons#1283)
<#1283 (comment)>
@austinweisgrau <https://github.com/austinweisgrau> is this still a work
in progress? It's missing docs and tests but I can do a review of the code
if you want, or I can wait til you're ready
—
Reply to this email directly, view it on GitHub
<#1283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO74QHTB7PQU2UWZQFPZJ5L2QOUDJAVCNFSM6AAAAABWVBE4OCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGAYTGNJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
I forget whether you've made a new connector before, but just in case you haven't or you forgot the steps, the new connector guide has all the details (probably too many details for your experience level!). Docs and tests sections are near the bottom. |
shaunagm
requested changes
Mar 11, 2025
Collaborator
shaunagm
left a comment
shaunagm
left a comment
There was a problem hiding this comment.
Just updating the status to 'request changes' as we need docs/tests. No rush!
austinweisgrau
force-pushed
the
daisychain
branch
from
e1957ba to
204af00
Compare
Collaborator
Author
|
Added docs and tests, should be good to go 🫡 |
shaunagm
reviewed
Jan 8, 2026
|
|
||
|
|
||
| class Daisychain: | ||
| def __init__(self, api_token: str): |
Collaborator
There was a problem hiding this comment.
This doesn't seem like it's doing the typical check for an environmental variable version of the api_token?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.